Return-Path: X-Original-To: apmail-incubator-sqoop-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-sqoop-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AC14399B0 for ; Thu, 1 Mar 2012 07:17:25 +0000 (UTC) Received: (qmail 94122 invoked by uid 500); 1 Mar 2012 07:17:25 -0000 Delivered-To: apmail-incubator-sqoop-dev-archive@incubator.apache.org Received: (qmail 94085 invoked by uid 500); 1 Mar 2012 07:17:25 -0000 Mailing-List: contact sqoop-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: sqoop-dev@incubator.apache.org Delivered-To: mailing list sqoop-dev@incubator.apache.org Delivered-To: moderator for sqoop-dev@incubator.apache.org Received: (qmail 81328 invoked by uid 99); 1 Mar 2012 07:12:33 -0000 Content-Type: multipart/alternative; boundary="===============7640472005659765574==" MIME-Version: 1.0 Subject: Re: Review Request: SQOOP-450. Direct mode MySQL fails in some cases. From: "Kate Ting" To: "Arvind Prabhakar" , "Sqoop" , "Kate Ting" Date: Thu, 01 Mar 2012 07:12:33 -0000 Message-ID: <20120301071233.7341.31783@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4121/ In-Reply-To: <20120301043942.13650.84514@reviews.apache.org> References: <20120301043942.13650.84514@reviews.apache.org> --===============7640472005659765574== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4121/#review5491 ----------------------------------------------------------- Ship it! Looks good! Thanks Arvind. - Kate On 2012-03-01 04:39:42, Arvind Prabhakar wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4121/ > ----------------------------------------------------------- > = > (Updated 2012-03-01 04:39:42) > = > = > Review request for Sqoop. > = > = > Summary > ------- > = > See Jira description for problem summary. The fix was to add the logic in= the mapper sinks to parse out and ignore empty lines and those that begin = with a comment marker. > = > = > This addresses bug SQOOP-450. > https://issues.apache.org/jira/browse/SQOOP-450 > = > = > Diffs > ----- > = > /src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1295369 = > = > Diff: https://reviews.apache.org/r/4121/diff > = > = > Testing > ------- > = > Ran DirectMySQLTest and MySQLAuthTest using mysqldump version 5.5.19 goin= g against server version 5.1.61 where this problem is reproducible. Also te= sted against a system with MySQL version 5.5.20 where this problem was orig= inally not reproducible. > = > Apart from this, ran the customary unit tests and third party tests. > = > = > Thanks, > = > Arvind > = > --===============7640472005659765574==--