-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/#review5344
-----------------------------------------------------------


Thanks for the patch!  Two comments below.


/src/java/org/apache/sqoop/tool/ImportTool.java
<https://reviews.apache.org/r/3961/#comment11659>

    This syntax ("AS alias") doesn't seem to work with Oracle.  You may want to try dropping the "AS" keyword, which seems to be accepted by most major databases.



/src/java/org/apache/sqoop/tool/ImportTool.java
<https://reviews.apache.org/r/3961/#comment11648>

    This replacement is specific to free form query?  If so, better move this to the else block above.


- Bilung


On 2012-02-19 20:35:48, Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3961/
> -----------------------------------------------------------
> 
> (Updated 2012-02-19 20:35:48)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Summary
> -------
> 
> I've incorporated support for incremental import of free form queries to sqoop.
> 
> 
> This addresses bug SQOOP-444.
>     https://issues.apache.org/jira/browse/SQOOP-444
> 
> 
> Diffs
> -----
> 
>   /src/java/org/apache/sqoop/tool/ImportTool.java 1245157 
>   /src/test/com/cloudera/sqoop/TestIncrementalImport.java 1245157 
> 
> Diff: https://reviews.apache.org/r/3961/diff
> 
> 
> Testing
> -------
> 
> ant -Dhadoopversion={20,23,100} test 
> live testing on CDH3 and Microsoft SQL Server
> 
> 
> Thanks,
> 
> Jarek
> 
>