From sqoop-dev-return-2060-apmail-incubator-sqoop-dev-archive=incubator.apache.org@incubator.apache.org Mon Feb 27 20:02:04 2012 Return-Path: X-Original-To: apmail-incubator-sqoop-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-sqoop-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B32E9D5A for ; Mon, 27 Feb 2012 20:02:04 +0000 (UTC) Received: (qmail 83113 invoked by uid 500); 27 Feb 2012 20:02:04 -0000 Delivered-To: apmail-incubator-sqoop-dev-archive@incubator.apache.org Received: (qmail 83071 invoked by uid 500); 27 Feb 2012 20:02:04 -0000 Mailing-List: contact sqoop-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: sqoop-dev@incubator.apache.org Delivered-To: mailing list sqoop-dev@incubator.apache.org Received: (qmail 83047 invoked by uid 99); 27 Feb 2012 20:02:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Feb 2012 20:02:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 19A351C03A2; Mon, 27 Feb 2012 20:02:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5327545059033535228==" MIME-Version: 1.0 Subject: Re: Review Request: SQOOP-444: Support incremental import for free form queries From: "Bilung Lee" To: "Arvind Prabhakar" , "Bilung Lee" Date: Mon, 27 Feb 2012 20:02:04 -0000 Message-ID: <20120227200204.13650.23939@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3961/ Cc: "Sqoop" , "Jarek Cecho" In-Reply-To: <20120219203548.19570.25759@reviews.apache.org> References: <20120219203548.19570.25759@reviews.apache.org> --===============5327545059033535228== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3961/#review5344 ----------------------------------------------------------- Thanks for the patch! Two comments below. /src/java/org/apache/sqoop/tool/ImportTool.java This syntax ("AS alias") doesn't seem to work with Oracle. You may wan= t to try dropping the "AS" keyword, which seems to be accepted by most majo= r databases. /src/java/org/apache/sqoop/tool/ImportTool.java This replacement is specific to free form query? If so, better move th= is to the else block above. - Bilung On 2012-02-19 20:35:48, Jarek Cecho wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3961/ > ----------------------------------------------------------- > = > (Updated 2012-02-19 20:35:48) > = > = > Review request for Sqoop, Arvind Prabhakar and Bilung Lee. > = > = > Summary > ------- > = > I've incorporated support for incremental import of free form queries to = sqoop. > = > = > This addresses bug SQOOP-444. > https://issues.apache.org/jira/browse/SQOOP-444 > = > = > Diffs > ----- > = > /src/java/org/apache/sqoop/tool/ImportTool.java 1245157 = > /src/test/com/cloudera/sqoop/TestIncrementalImport.java 1245157 = > = > Diff: https://reviews.apache.org/r/3961/diff > = > = > Testing > ------- > = > ant -Dhadoopversion=3D{20,23,100} test = > live testing on CDH3 and Microsoft SQL Server > = > = > Thanks, > = > Jarek > = > --===============5327545059033535228==--