sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-444) Support incremental import for free form queries
Date Mon, 27 Feb 2012 20:04:46 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217486#comment-13217486
] 

jiraposter@reviews.apache.org commented on SQOOP-444:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/#review5344
-----------------------------------------------------------


Thanks for the patch!  Two comments below.


/src/java/org/apache/sqoop/tool/ImportTool.java
<https://reviews.apache.org/r/3961/#comment11659>

    This syntax ("AS alias") doesn't seem to work with Oracle.  You may want to try dropping
the "AS" keyword, which seems to be accepted by most major databases.



/src/java/org/apache/sqoop/tool/ImportTool.java
<https://reviews.apache.org/r/3961/#comment11648>

    This replacement is specific to free form query?  If so, better move this to the else
block above.


- Bilung


On 2012-02-19 20:35:48, Jarek Cecho wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3961/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-19 20:35:48)
bq.  
bq.  
bq.  Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  I've incorporated support for incremental import of free form queries to sqoop.
bq.  
bq.  
bq.  This addresses bug SQOOP-444.
bq.      https://issues.apache.org/jira/browse/SQOOP-444
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/java/org/apache/sqoop/tool/ImportTool.java 1245157 
bq.    /src/test/com/cloudera/sqoop/TestIncrementalImport.java 1245157 
bq.  
bq.  Diff: https://reviews.apache.org/r/3961/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  ant -Dhadoopversion={20,23,100} test 
bq.  live testing on CDH3 and Microsoft SQL Server
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jarek
bq.  
bq.


                
> Support incremental import for free form queries
> ------------------------------------------------
>
>                 Key: SQOOP-444
>                 URL: https://issues.apache.org/jira/browse/SQOOP-444
>             Project: Sqoop
>          Issue Type: New Feature
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>         Attachments: SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message