sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: SQOOP-439: Released artifacts should embrace unwritten naming policy
Date Wed, 22 Feb 2012 02:22:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3949/#review5257
-----------------------------------------------------------

Ship it!


Look good overall.  Just one minor suggestion below.


/build.xml
<https://reviews.apache.org/r/3949/#comment11474>

    value="${artifact.name}"


- Bilung


On 2012-02-18 16:15:07, Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3949/
> -----------------------------------------------------------
> 
> (Updated 2012-02-18 16:15:07)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Summary
> -------
> 
> I've changed ant configuration to generate artifacts based on policy that we agreed on
JIRA for both source and binary releases. 
> 
> I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate
binary artifacts for all supported versions at once, however I wasn't able to get it working
in reasonable time. 
> 
> I'll update wiki page "How to Release" in case that this patch will be accepted.
> 
> 
> This addresses bug SQOOP-439.
>     https://issues.apache.org/jira/browse/SQOOP-439
> 
> 
> Diffs
> -----
> 
>   /build.xml 1245157 
> 
> Diff: https://reviews.apache.org/r/3949/diff
> 
> 
> Testing
> -------
> 
> ant srctar
> ant tar
> - Inside generated artifacts both "ant test" and "ant releaseaudit"
> 
> 
> Thanks,
> 
> Jarek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message