From reviews-return-1333912-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Jul 23 10:59:05 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id EC5B8180654 for ; Fri, 23 Jul 2021 12:59:04 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 6129260551 for ; Fri, 23 Jul 2021 10:59:04 +0000 (UTC) Received: (qmail 49204 invoked by uid 500); 23 Jul 2021 10:59:03 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 49192 invoked by uid 99); 23 Jul 2021 10:59:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jul 2021 10:59:03 +0000 From: =?utf-8?q?GitBox?= To: reviews@spark.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bspark=5D_EnricoMi_commented_on_a_change_in_pull_re?= =?utf-8?q?quest_=2333484=3A_=5BSPARK-36263=5D=5BSQL=5D=5BPYTHON=5D_Add_Data?= =?utf-8?q?frame=2Eobservation_to_PySpark?= Message-ID: <162703794363.16310.18399800762387589385.asfpy@gitbox.apache.org> Date: Fri, 23 Jul 2021 10:59:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: EnricoMi commented on a change in pull request #33484: URL: https://github.com/apache/spark/pull/33484#discussion_r675482040 ########## File path: dev/sparktestsupport/modules.py ########## @@ -437,6 +437,7 @@ def __hash__(self): "pyspark.sql.pandas.serializers", "pyspark.sql.pandas.typehints", "pyspark.sql.pandas.utils", + "pyspark.sql.observation", Review comment: so many magic places... done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org