From reviews-return-1330887-archive-asf-public=cust-asf.ponee.io@spark.apache.org Tue Jul 20 11:56:33 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id A6613180658 for ; Tue, 20 Jul 2021 13:56:33 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 2E685602C5 for ; Tue, 20 Jul 2021 11:56:33 +0000 (UTC) Received: (qmail 35884 invoked by uid 500); 20 Jul 2021 11:56:32 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 35872 invoked by uid 99); 20 Jul 2021 11:56:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jul 2021 11:56:32 +0000 From: =?utf-8?q?GitBox?= To: reviews@spark.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bspark=5D_cloud-fan_commented_on_a_change_in_pull_r?= =?utf-8?q?equest_=2333299=3A_=5BSPARK-36046=5D=5BSQL=5D_Support_new_functio?= =?utf-8?q?ns_make=5Ftimestamp=5Fntz_and_make=5Ftimestamp=5Fltz?= Message-ID: <162678219248.6490.12545403002229662274.asfpy@gitbox.apache.org> Date: Tue, 20 Jul 2021 11:56:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: cloud-fan commented on a change in pull request #33299: URL: https://github.com/apache/spark/pull/33299#discussion_r672400696 ########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ########## @@ -552,6 +552,8 @@ object FunctionRegistry { expression[TimeWindow]("window"), expression[MakeDate]("make_date"), expression[MakeTimestamp]("make_timestamp"), + expression[MakeTimestampNTZ]("make_timestamp_ntz", true), Review comment: @beliefer can you fix it in a followup pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org