From reviews-return-1327380-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Jul 15 21:14:26 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 5156D180661 for ; Thu, 15 Jul 2021 23:14:26 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 905BA3EEC6 for ; Thu, 15 Jul 2021 21:14:25 +0000 (UTC) Received: (qmail 1077 invoked by uid 500); 15 Jul 2021 21:14:25 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 1065 invoked by uid 99); 15 Jul 2021 21:14:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jul 2021 21:14:25 +0000 From: =?utf-8?q?GitBox?= To: reviews@spark.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bspark=5D_tdas_commented_on_a_change_in_pull_reques?= =?utf-8?q?t_=2333336=3A_=5BSPARK-36132=5D=5BSS=5D=5BSQL=5D_Support_initial_?= =?utf-8?q?state_for_batch_mode_of_flatMapGroupsWithState?= Message-ID: <162638366531.6490.16443025338298346472.asfpy@gitbox.apache.org> Date: Thu, 15 Jul 2021 21:14:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: tdas commented on a change in pull request #33336: URL: https://github.com/apache/spark/pull/33336#discussion_r670809632 ########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala ########## @@ -404,3 +402,72 @@ case class FlatMapGroupsWithStateExec( copy(child = newLeft, initialState = newRight) } +object FlatMapGroupsWithStateExec { + + def foundDuplicateInitialKeyException(): Exception = { + throw new IllegalArgumentException("The initial state provided contained " + + "multiple rows(state) with the same key. Make sure to de-duplicate the " + + "initial state before passing it.") + } + + /** + * Special handling for when the child relation is a batch relation. Review comment: what is the handling here? the doc should say plan logical flatmapGroupsWIthState for batch queries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org