From reviews-return-1313880-archive-asf-public=cust-asf.ponee.io@spark.apache.org Tue Jun 22 08:14:39 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id CD4C5180669 for ; Tue, 22 Jun 2021 10:14:39 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id B86A940002 for ; Tue, 22 Jun 2021 08:13:49 +0000 (UTC) Received: (qmail 79065 invoked by uid 500); 22 Jun 2021 08:13:49 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 79037 invoked by uid 99); 22 Jun 2021 08:13:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jun 2021 08:13:49 +0000 From: =?utf-8?q?GitBox?= To: reviews@spark.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bspark=5D_Peng-Lei_opened_a_new_pull_request_=23330?= =?utf-8?q?14=3A_=5BSPARK-35728=5D=5BSQL=5D=5BTESTS=5D_Check_multiply/divide?= =?utf-8?q?_of_day-time_intervals_of_any_fields_by_numeric?= Message-ID: Date: Tue, 22 Jun 2021 08:13:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Peng-Lei opened a new pull request #33014: URL: https://github.com/apache/spark/pull/33014 ### What changes were proposed in this pull request? 1. The testcase is just cover the DayTimeIntervalType() */ numeric 2. Add following intervals */ numeric: INTERVAL DAY INTERVAL DAY TO HOUR INTERVAL DAY TO MINUTE INTERVAL HOUR INTERVAL HOUR TO MINUTE INTERVAL HOUR TO SECOND INTERVAL MINUTE INTERVAL MINUTE TO SECOND INTERVAL SECOND ### Why are the changes needed? Add testcase coverage. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existed testcase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org