spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] Ngone51 edited a comment on pull request #32790: [SPARK-35543][CORE] Fix memory leak in BlockManagerMasterEndpoint removeRdd
Date Mon, 07 Jun 2021 08:27:38 GMT

Ngone51 edited a comment on pull request #32790:
URL: https://github.com/apache/spark/pull/32790#issuecomment-855709345


   > Why are you sure about that? Just looking only these lines?
   
   It's only called by `BlockManagerMasterEndpoint.removeRdd() -> removeBlock()` in production
code path, right?
   
   > Do we?
   
   ~~First, I'm talking about the production code not testing code.~~  (I misread the `TaskResultBlockId`
as `TestResultBlockId `, I'm looking at this now.) I said we only have broadcast blocks and
rdd blocks here because it comes from `BlockManagerMasterEndpoint.updateBlockInfo -> updateBlockInfo`.
At there, shuffle blocks are excluded so only  broadcast blocks and rdd blocks are handled.
   
   
   > With my phone I cannot fix it (although a vim probably would run just fine on it ;)
but having no keyboard no sbt..) so it would disturb me a lot and it could ruin my vacation
what I do not want risk.
   
   Sure, no worries. Your current fix already resolves the issue so it's ok to merge. We don't
have to block on my suggestion. We can discuss more when you're available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message