From reviews-return-1263836-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Mar 12 01:26:09 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 3CAB7180652 for ; Fri, 12 Mar 2021 02:26:09 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 7A09241F92 for ; Fri, 12 Mar 2021 01:26:08 +0000 (UTC) Received: (qmail 60287 invoked by uid 500); 12 Mar 2021 01:26:08 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 60262 invoked by uid 99); 12 Mar 2021 01:26:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Mar 2021 01:26:07 +0000 From: =?utf-8?q?GitBox?= To: reviews@spark.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bspark=5D_maropu_commented_on_a_change_in_pull_requ?= =?utf-8?q?est_=2331792=3A_=5BSPARK-34681=5D=5BSQL=5D_Fix_bug_for_full_outer?= =?utf-8?q?_shuffled_hash_join_when_building_left_side_with_non-equal_condit?= =?utf-8?q?ion?= Message-ID: <161551236775.15632.9700700217872216906.asfpy@gitbox.apache.org> Date: Fri, 12 Mar 2021 01:26:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: maropu commented on a change in pull request #31792: URL: https://github.com/apache/spark/pull/31792#discussion_r592846480 ########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ########## @@ -137,7 +137,13 @@ trait HashJoin extends JoinCodegenSupport { UnsafeProjection.create(streamedBoundKeys) @transient protected[this] lazy val boundCondition = if (condition.isDefined) { - Predicate.create(condition.get, streamedPlan.output ++ buildPlan.output).eval _ + if (joinType == FullOuter && buildSide == BuildLeft) { + // Put join left side before right side. This is to be consistent with + // `ShuffledHashJoinExec.fullOuterJoin`. + Predicate.create(condition.get, buildPlan.output ++ streamedPlan.output).eval _ Review comment: Nice catch! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org