spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] aokolnychyi commented on a change in pull request #31093: [SPARK-34049][SS] DataSource V2: Use Write abstraction in StreamExecution
Date Sat, 09 Jan 2021 07:49:00 GMT

aokolnychyi commented on a change in pull request #31093:
URL: https://github.com/apache/spark/pull/31093#discussion_r554306458



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTable.scala
##########
@@ -274,11 +274,13 @@ class InMemoryTable(
         this
       }
 
-      override def buildForBatch(): BatchWrite = writer

Review comment:
       Yeah, we could leave it as is. I changed because it would previously fail if a data
source implemented the build method only. 
   
   In the next PR, I am going to implement RequireaDistributionAndOrdering.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message