spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] viirya commented on a change in pull request #30885: [SPARK-33659][SS] Document the current behavior for DataStreamWriter.toTable API
Date Tue, 22 Dec 2020 17:48:47 GMT

viirya commented on a change in pull request #30885:
URL: https://github.com/apache/spark/pull/30885#discussion_r547414829



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
##########
@@ -301,12 +301,24 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) {
   def start(): StreamingQuery = startInternal(None)
 
   /**
+   * :: Experimental ::
+   *
    * Starts the execution of the streaming query, which will continually output results to
the given
    * table as new data arrives. A new table will be created if the table not exists. The
returned

Review comment:
       Here it documented a new table will be created if not existing, but later it also documents
"Please create a table manually before the execution". It looks confusing, I think. Could
we rephrase them together and give a more concrete description about table creation?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message