spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [spark] imback82 opened a new pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Date Fri, 06 Nov 2020 02:42:24 GMT

imback82 opened a new pull request #30270:

   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines:
     2. Ensure you have added or run the appropriate tests for your PR:
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your
PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming
configurations in
   ### What changes were proposed in this pull request?
   Please clarify what changes you are proposing. The purpose of this section is to outline
the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your
PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will
help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   This PR proposes to migrate `LOAD DATA` to use `UnresolvedTable` to resolve the table identifier.
This allows consistent resolution rules (temp view first, etc.) to be applied for both v1/v2
commands. More info about the consistent resolution rule proposal can be found in [JIRA](
or [proposal doc](
   Note that `LOAD DATA` is not supported for v2 tables.
   ### Why are the changes needed?
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   The changes allow consistent resolution behavior when resolving the table identifier. For
example, the following is the current behavior:
   sql("CREATE DATABASE db")
   sql("CREATE TABLE t (key INT, value STRING) USING hive")
   sql("USE db")
   sql("LOAD DATA LOCAL INPATH 'examples/src/main/resources/kv1.txt' INTO TABLE t") // Succeeds
   With this change, LOAD DATA above fails with the following:
   org.apache.spark.sql.AnalysisException: t is a temp view not table.; line 1 pos 0
       at org.apache.spark.sql.catalyst.analysis.package$AnalysisErrorAt.failAnalysis(package.scala:42)
       at org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveTempViews$$anonfun$apply$7.$anonfun$applyOrElse$39(Analyzer.scala:865)
       at scala.Option.foreach(Option.scala:407)
   , which is expected since temporary view is resolved first and LOAD DATA doesn't support
a temporary view.
   ### Does this PR introduce _any_ user-facing change?
   Note that it means *any* user-facing change including all aspects such as the documentation
   If yes, please clarify the previous behavior and the change this PR proposes - provide
the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released
Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   After this PR, `LOAD DATA ... t` is resolved to a temp view `t` instead of table `db.t`
in the above scenario.
   ### How was this patch tested?
   If tests were added, say they were added here. Please make sure to add some test cases
that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested
step by step, ideally copy and paste-able, so that other reviewers can test and check, and
descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult
to add.
   Updated existing tests.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message