spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HeartSaVioR edited a comment on pull request #30210: [SPARK-33259][SS] Disable streaming query with possible correctness issue by default
Date Fri, 13 Nov 2020 00:09:05 GMT

HeartSaVioR edited a comment on pull request #30210:
URL: https://github.com/apache/spark/pull/30210#issuecomment-726418896


   That's not my point. There's no indication I have produced all review comments (while actually
I produced all review comments), and review comment author would be the right one to verify
whether the review comments are addressed as suggested. I planned to review the new change
again today but it's already merged.
   
   I see we tend to ask reviewers to see whether they're happy with the last change before
merging. At least we "were", and I tend to ensure that, unless reviewers are not responded
for days. I'd hope we ensure everyone is happy with the change before merging, otherwise discuss/debate
if necessary.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message