spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] anchovYu commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file
Date Thu, 10 Sep 2020 06:31:26 GMT

anchovYu commented on pull request #29497:
URL: https://github.com/apache/spark/pull/29497#issuecomment-690019832


   > 1. Is it only for certain exceptions or all exceptions? For example, this PR targets
only AnalysisException.
   
   In the ideal case, all exception messages should be grouped for easy maintenance and auditing.
This PR first starts from the `AnalyzerException`s in Catalyst.
   
   And yeah, if we want to divide these exceptions in groups, then the mapping rule, and how
to divide so that contributors can easily follow the rule to commit is a problem. And, another
concern of the `QueryCompilationErrors` and `QueryExecutionErrors` is that they are different
package names + same object name. When developers would like to call functions of compilation
errors from different components, they may have to write the full package name. 
   
   Grouping exceptions in a single file will necessarily explode the file size; but I think
the process is that first we group them, then we look for ways to optimize them, for example,
find the duplicate error messages and combine them in one function, or, divide them into smaller
and refined groups.
   
   Open to all ideas and great thanks for your review! cc @cloud-fan @maropu @viirya 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message