spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dbaliafroozeh commented on a change in pull request #29598: [SPARK-32755][SQL] Maintain the order of expressions in AttributeSet and ExpressionSet
Date Fri, 04 Sep 2020 08:48:31 GMT

dbaliafroozeh commented on a change in pull request #29598:
URL: https://github.com/apache/spark/pull/29598#discussion_r483479941



##########
File path: sql/catalyst/src/main/scala-2.12/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala
##########
@@ -27,6 +27,10 @@ object ExpressionSet {
     expressions.foreach(set.add)
     set
   }
+

Review comment:
       @cloud-fan good catch, I thought I already delete the ExpressionSet in 2.13. Note that
we don't want it anymore as ExpressionSet doesn't extend Set anymore. I'll open a followup
PR for that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message