spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] holdenk commented on a change in pull request #27568: [SPARK-30821][K8S]Handle container failure in executor pods with multiple containers
Date Wed, 26 Aug 2020 18:37:26 GMT

holdenk commented on a change in pull request #27568:
URL: https://github.com/apache/spark/pull/27568#discussion_r477507291



##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorLifecycleTestUtils.scala
##########
@@ -71,6 +71,27 @@ object ExecutorLifecycleTestUtils {
       .build()
   }
 
+  def runningExecutorWithFailedContainer(executorId: Long): Pod = {

Review comment:
       Maybe add a comment on the purpose of this function? Namely setting the pod to failed
iff the executor container fails. Also might this make sense to be configurable? I can imagine
people who have sidecars for stuff like istio, if the sidecar fails the pod should fail since
the networking isn't going to work. WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message