spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] cloud-fan commented on pull request #29125: [SPARK-32018][SQL][3.0] UnsafeRow.setDecimal should set null with overflowed value
Date Fri, 07 Aug 2020 04:55:13 GMT

cloud-fan commented on pull request #29125:
URL: https://github.com/apache/spark/pull/29125#issuecomment-670321237


   OK let me clarify a few things:
   1. I agree with you that making Spark more likely to return incorrect results is not acceptable.
   2. I hope you understand that having a bug in the very fundamental `UnsafeRow` is not acceptable
either.
   
   I'll ask someone to implement the ANSI behavior for decimal sum in 3.0 and 2.4, so that
it fails instead of returning wrong results.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message