spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] srowen commented on pull request #28553: [SPARK-31734][ML][PySpark] Add weight support in ClusteringEvaluator
Date Fri, 22 May 2020 16:37:41 GMT

srowen commented on pull request #28553:
URL: https://github.com/apache/spark/pull/28553#issuecomment-632790127


   Yeah there are several points in the code that check weights with a `require`. I don't
know if they can be refactored easily. Your approach is fine. Other places check it farther
downstream inside some other operation but it doesn't matter much.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message