From reviews-return-1069857-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Mar 25 19:37:27 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 83B9718063D for ; Wed, 25 Mar 2020 20:37:27 +0100 (CET) Received: (qmail 38253 invoked by uid 500); 25 Mar 2020 19:37:26 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 38241 invoked by uid 99); 25 Mar 2020 19:37:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Mar 2020 19:37:26 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] dongjoon-hyun commented on a change in pull request #28015: [SPARK-31244][K8S][TEST] Use Minio instead of Ceph in K8S DepsTestsSuite Message-ID: <158516504674.14983.17502709305709673203.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 25 Mar 2020 19:37:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dongjoon-hyun commented on a change in pull request #28015: [SPARK-31244][K8S][TEST] Use Minio instead of Ceph in K8S DepsTestsSuite URL: https://github.com/apache/spark/pull/28015#discussion_r398119557 ########## File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala ########## @@ -59,13 +58,14 @@ private[spark] trait DepsTestsSuite { k8sSuite: KubernetesSuite => ).asJava new ContainerBuilder() - .withImage("ceph/daemon:v4.0.3-stable-4.0-nautilus-centos-7-x86_64") + .withImage("minio/minio:latest") .withImagePullPolicy("Always") .withName(cName) + .withArgs("server", "/data") Review comment: Yes, right! `minio` docker image needs these argument. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org