From reviews-return-1061579-archive-asf-public=cust-asf.ponee.io@spark.apache.org Sun Mar 15 18:26:29 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7DE29180637 for ; Sun, 15 Mar 2020 19:26:29 +0100 (CET) Received: (qmail 46278 invoked by uid 500); 15 Mar 2020 18:26:28 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 46265 invoked by uid 99); 15 Mar 2020 18:26:28 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Mar 2020 18:26:28 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] kyrill007 commented on issue #27918: [SPARK-31071][SQL][Follow-up] Support nonnull annotation by field directly Message-ID: <158429678869.17903.9779828463685346745.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 15 Mar 2020 18:26:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit kyrill007 commented on issue #27918: [SPARK-31071][SQL][Follow-up] Support nonnull annotation by field directly URL: https://github.com/apache/spark/pull/27918#issuecomment-599246596 This change would mean that the _property_ should not be marked as @Nonnull. I mean, it is up to the author to ensure that the properties can never be null if the annotation is in place. I see your point now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org