From reviews-return-1060335-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Mar 13 05:03:57 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 47EDF18064F for ; Fri, 13 Mar 2020 06:03:57 +0100 (CET) Received: (qmail 17787 invoked by uid 500); 13 Mar 2020 05:03:56 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 17774 invoked by uid 99); 13 Mar 2020 05:03:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Mar 2020 05:03:56 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] dongjoon-hyun commented on issue #27834: [SPARK-31091] Revert SPARK-24640 Return `NULL` from `size(NULL)` by default Message-ID: <158407583625.28120.3609852969032549477.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 13 Mar 2020 05:03:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dongjoon-hyun commented on issue #27834: [SPARK-31091] Revert SPARK-24640 Return `NULL` from `size(NULL)` by default URL: https://github.com/apache/spark/pull/27834#issuecomment-598550554 Since it has already `legacy` in the name, `spark.sql.legacy.sizeOfNull`, `true` just means preserving the old behavior, whatever it was. So, in that sense, the current name is also okay. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org