From reviews-return-1053488-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Mar 4 17:18:59 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BC35718063F for ; Wed, 4 Mar 2020 18:18:58 +0100 (CET) Received: (qmail 25021 invoked by uid 500); 4 Mar 2020 17:18:58 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 25008 invoked by uid 99); 4 Mar 2020 17:18:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2020 17:18:58 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] cloud-fan commented on a change in pull request #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone Message-ID: <158334233807.19625.15198840560762816970.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 04 Mar 2020 17:18:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cloud-fan commented on a change in pull request #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone URL: https://github.com/apache/spark/pull/27792#discussion_r387814355 ########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ########## @@ -75,6 +77,10 @@ object SQLConf { } } + def isValidTimezone(zone: String): Boolean = { Review comment: can we move it closer to where it's used? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org