spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] nchammas opened a new pull request #27917: [SPARK-31153][BUILD] Cleanup several failures in lint-python
Date Sun, 15 Mar 2020 05:13:29 GMT
nchammas opened a new pull request #27917: [SPARK-31153][BUILD] Cleanup several failures in
lint-python
URL: https://github.com/apache/spark/pull/27917
 
 
   Backport of #27910 / 0ce5519f179a8f88a688dece754596c3166528b7.
   
   ---
   
   This PR cleans up several failures -- most of them silent -- in `dev/lint-python`. I don't
understand how we haven't been bitten by these yet. Perhaps we've been lucky?
   
   Fixes include:
   * Fix how we compare versions. All the version checks currently in `master` silently fail
with:
   
       ```
         File "<string>", line 2
           print(LooseVersion("""2.3.1""") >= LooseVersion("""2.4.0"""))
           ^
       IndentationError: unexpected indent
       ```
       Another problem is that `distutils.version` is undocumented and unsupported.
   * Fix some basic bugs. e.g. We have an incorrect reference to `$PYDOCSTYLEBUILD`, which
doesn't exist, which was causing the doc style test to silently fail with:
   
       ```
       ./dev/lint-python: line 193: --version: command not found
       ```
   * Stop suppressing error output! It's hiding problems and serves no purpose here.
   
   `lint-python` is part of our CI build and is currently doing any combination of the following:
silently failing; incorrectly skipping tests; incorrectly downloading libraries when a suitable
library is already available.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message