spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun edited a comment on issue #28016: [SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in write/read for ORC datasource
Date Thu, 26 Mar 2020 19:44:41 GMT
dongjoon-hyun edited a comment on issue #28016: [SPARK-31238][SQL][test-hive1.2] Rebase dates
to/from Julian calendar in write/read for ORC datasource
URL: https://github.com/apache/spark/pull/28016#issuecomment-604645378
 
 
   Ur, are you asking why we keep `v1.2` and `v2.3` structure?
   In this PR, you are proposing the following weird structure. And, I'm not sure if you check
what happens at `DaysWritable` when you use `hive-1.2` profile.
   ```
   sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DaysWritable.scala
   sql/core/v1.2/src/main/scala/org/apache/spark/sql/execution/datasources/orc/DaysWritable.scala
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message