spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] rdblue commented on a change in pull request #28026: [SPARK-31257][SQL] Unify create table syntax (WIP)
Date Thu, 26 Mar 2020 16:54:47 GMT
rdblue commented on a change in pull request #28026: [SPARK-31257][SQL] Unify create table
syntax (WIP)
URL: https://github.com/apache/spark/pull/28026#discussion_r398732356
 
 

 ##########
 File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java
 ##########
 @@ -46,6 +46,11 @@
    */
   String PROP_LOCATION = "location";
 
+  /**
+   * A reserved property to specify a table was created with EXTERNAL.
+   */
+  String PROP_EXTERNAL = "external";
 
 Review comment:
   It is up to source providers how to handle this. If the parser accepts `EXTERNAL` then
the fact that it was added should be passed to sources.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message