spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] maropu commented on a change in pull request #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Date Thu, 26 Mar 2020 01:21:22 GMT
maropu commented on a change in pull request #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix
bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398264464
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/comments.sql
 ##########
 @@ -1,12 +1,5 @@
 -- Test comments.
-
--- the first case of bracketed comment
---QUERY-DELIMITER-START
-/* This is the first example of bracketed comment.
-SELECT 'ommented out content' AS first;
-*/
-SELECT 'selected content' AS first;
---QUERY-DELIMITER-END
+--IMPORT nested-comments.sql
 
 Review comment:
   Also, could you put an output example before/after this PR in the PR description?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message