spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HeartSaVioR commented on issue #27872: [SPARK-31115][SQL] Detect known Janino bug janino-compiler/janino#113 and apply workaround automatically as a fail-back via avoid using switch statement in generated code
Date Tue, 17 Mar 2020 07:46:28 GMT
HeartSaVioR commented on issue #27872: [SPARK-31115][SQL] Detect known Janino bug janino-compiler/janino#113
and apply workaround automatically as a fail-back via avoid using switch statement in generated
code
URL: https://github.com/apache/spark/pull/27872#issuecomment-599924340
 
 
   Thanks for the detailed explanation, @rednaxelafx !
   
   Btw, as I shared earlier, I have been investigating with Janino itself - I fixed all of
bugs on 3.1.x which made Spark UT failing, and hopefully Janino maintainer made a branch for
3.0.x as well. Maybe we can get both of 3.0.16 & 3.1.2 versions in this week, and then
we can simply upgrade Janino to abandon this PR.
   
   I'm running UT in #27860 for Janino 3.1.2 (custom jar via Jitpack) as well as #27932 for
Janino 3.0.16 (custom jar via Jitpack). Once both builds run fine, I'll forward the result
to Janino maintainer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message