spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] yaooqinn commented on a change in pull request #27906: [SPARK-31150][SQL] Parsing seconds fraction with variable length for timestamp
Date Tue, 17 Mar 2020 05:51:06 GMT
yaooqinn commented on a change in pull request #27906: [SPARK-31150][SQL] Parsing seconds fraction
with variable length for timestamp
URL: https://github.com/apache/spark/pull/27906#discussion_r393457332
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/util/TimestampFormatterSuite.scala
 ##########
 @@ -64,7 +65,8 @@ class TimestampFormatterSuite extends SparkFunSuite with SQLHelper with
Matchers
     DateTimeTestUtils.outstandingTimezonesIds.foreach { zoneId =>
       val formatter = TimestampFormatter(
         "yyyy-MM-dd'T'HH:mm:ss.SSSSSS",
-        DateTimeUtils.getZoneId(zoneId))
+        DateTimeUtils.getZoneId(zoneId),
+        needVarLengthSecondFraction = true)
 
 Review comment:
   oh. I mean this should be false too. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message