spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] srowen commented on a change in pull request #27895: [SPARK-31138][ML] Add ANOVA Selector for continuous features and categorical labels
Date Sun, 15 Mar 2020 18:37:07 GMT
srowen commented on a change in pull request #27895: [SPARK-31138][ML] Add ANOVA Selector for
continuous features and categorical labels
URL: https://github.com/apache/spark/pull/27895#discussion_r392700231
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/stat/FValueTest.scala
 ##########
 @@ -44,7 +44,7 @@ object FValueTest {
    * @return DataFrame containing the test result for every feature against the label.
    *         This DataFrame will contain a single Row with the following fields:
    *          - `pValues: Vector`
-   *          - `degreesOfFreedom: Array[Int]`
+   *          - `degreesOfFreedom: Array[Long]`
 
 Review comment:
   Can DoF really be so large that a long is needed? No big deal; if that's how it works now
and you're just correcting docs, that's OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message