spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HeartSaVioR commented on issue #27872: [SPARK-31115][SQL] Detect known Janino bug janino-compiler/janino#113 and apply workaround automatically as a fail-back via avoid using switch statement in generated code
Date Sat, 14 Mar 2020 13:54:38 GMT
HeartSaVioR commented on issue #27872: [SPARK-31115][SQL] Detect known Janino bug janino-compiler/janino#113
and apply workaround automatically as a fail-back via avoid using switch statement in generated
code
URL: https://github.com/apache/spark/pull/27872#issuecomment-599064274
 
 
   > btw, splitting large code into pieces in switch is a solution for this issue? Additionally,
we need to replace switch with if?
   > I just want to know the actual performance numbers of this approach. I think splitting
large code into small parts might improve performance.
   
   This patch is intended to add workaround for the bug until the actual patch will be placed
into Janino; it would be nice if we could develop the ideas of "improvement" via separate
thread. I'm not an expert of JVM so not clear how much JIT would help (if what we expect from
making method lines smaller is just inlining the method, that would be technically same as
before).
   
   That's why I've been also investigating to go forward with option 1 as well; this patch
can be simply abandoned if we are OK with #27860 (for sure, with official release of Janino).
   
   > To reproduce the issue, could you build the simple query that you can show us based
on your private customer's query? I think the query can make us understood more for the issue.
   
   I've added UT which fails in master branch. I've also added comments around UT to explain
the details. I don't think it would require very complicated query; lots of columns and enough
number of distinct aggregation function will trigger the bug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message