spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HeartSaVioR commented on a change in pull request #27763: [SPARK-31013][Core][WebUI] InMemoryStore: improve removeAllByIndexValues over natural key index
Date Mon, 02 Mar 2020 23:17:16 GMT
HeartSaVioR commented on a change in pull request #27763: [SPARK-31013][Core][WebUI] InMemoryStore:
improve removeAllByIndexValues over natural key index
URL: https://github.com/apache/spark/pull/27763#discussion_r386709547
 
 

 ##########
 File path: common/kvstore/src/main/java/org/apache/spark/util/kvstore/InMemoryStore.java
 ##########
 @@ -271,9 +276,9 @@ public void put(T value) throws Exception {
       }
     }
 
-    public void delete(Object key) {
-      data.remove(asKey(key));
-      if (hasNaturalParentIndex) {
+    public Boolean delete(Object key) {
 
 Review comment:
   At a glance, it could be primitive `boolean` here and below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message