From reviews-return-1049684-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Feb 28 10:27:15 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A19A0180636 for ; Fri, 28 Feb 2020 11:27:15 +0100 (CET) Received: (qmail 50456 invoked by uid 500); 28 Feb 2020 10:27:15 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 50442 invoked by uid 99); 28 Feb 2020 10:27:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Feb 2020 10:27:15 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] beliefer commented on a change in pull request #27734: [SPARK-30908][CORE][DOC] Add version information to the configuration of Kryo Message-ID: <158288563501.12545.9095688524964486687.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 28 Feb 2020 10:27:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit beliefer commented on a change in pull request #27734: [SPARK-30908][CORE][DOC] Add version information to the configuration of Kryo URL: https://github.com/apache/spark/pull/27734#discussion_r385617961 ########## File path: core/src/main/scala/org/apache/spark/internal/config/Kryo.scala ########## @@ -22,35 +22,43 @@ import org.apache.spark.network.util.ByteUnit private[spark] object Kryo { val KRYO_REGISTRATION_REQUIRED = ConfigBuilder("spark.kryo.registrationRequired") + .version("1.1.0") .booleanConf .createWithDefault(false) val KRYO_USER_REGISTRATORS = ConfigBuilder("spark.kryo.registrator") + .version("0.5.0") .stringConf .createOptional val KRYO_CLASSES_TO_REGISTER = ConfigBuilder("spark.kryo.classesToRegister") + .version("1.2.0") .stringConf .toSequence .createWithDefault(Nil) val KRYO_USE_UNSAFE = ConfigBuilder("spark.kryo.unsafe") + .version("2.1.0") .booleanConf .createWithDefault(false) val KRYO_USE_POOL = ConfigBuilder("spark.kryo.pool") + .version("3.0.0") .booleanConf .createWithDefault(true) val KRYO_REFERENCE_TRACKING = ConfigBuilder("spark.kryo.referenceTracking") + .version("0.8.0") Review comment: No JIRA ID, commit ID: 0a8cc309211c62f8824d76618705c817edcf2424#diff-1f81c62dad0e2dfc387a974bb08c497c ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org