From reviews-return-1046918-archive-asf-public=cust-asf.ponee.io@spark.apache.org Tue Feb 25 09:10:55 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 089BF18025F for ; Tue, 25 Feb 2020 10:10:54 +0100 (CET) Received: (qmail 67360 invoked by uid 500); 25 Feb 2020 09:10:54 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 67348 invoked by uid 99); 25 Feb 2020 09:10:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Feb 2020 09:10:54 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] beliefer commented on a change in pull request #27691: [SPARK-30841][SQL][DOC] Add version information to the configuration of SQL Message-ID: <158262185435.30832.928406024484243327.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 25 Feb 2020 09:10:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit beliefer commented on a change in pull request #27691: [SPARK-30841][SQL][DOC] Add version information to the configuration of SQL URL: https://github.com/apache/spark/pull/27691#discussion_r383743995 ########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ########## @@ -422,20 +453,23 @@ object SQLConf { .doc(s"When true and '${ADAPTIVE_EXECUTION_ENABLED.key}' is enabled, this enables the " + "optimization of converting the shuffle reader to local shuffle reader for the shuffle " + "exchange of the broadcast hash join in probe side.") + .version("3.0.0") .booleanConf .createWithDefault(true) val ADAPTIVE_EXECUTION_SKEWED_JOIN_ENABLED = buildConf("spark.sql.adaptive.skewedJoinOptimization.enabled") .doc("When true and adaptive execution is enabled, a skewed join is automatically handled at " + "runtime.") + .version("3.0.0") Review comment: , commit ID: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org