From reviews-return-1043700-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Feb 20 11:04:07 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1B7EE18067A for ; Thu, 20 Feb 2020 12:04:06 +0100 (CET) Received: (qmail 27535 invoked by uid 500); 20 Feb 2020 11:04:05 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 27465 invoked by uid 99); 20 Feb 2020 11:04:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Feb 2020 11:04:04 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] cloud-fan commented on a change in pull request #27560: [SPARK-30809][SQL] Review and fix issues in SQL API docs Message-ID: <158219664469.10972.6022380527828538355.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 20 Feb 2020 11:04:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cloud-fan commented on a change in pull request #27560: [SPARK-30809][SQL] Review and fix issues in SQL API docs URL: https://github.com/apache/spark/pull/27560#discussion_r381930412 ########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala ########## @@ -488,6 +488,8 @@ object DataType { /** * Jackson serializer for [[DataType]]. Internally this delegates to json4s based serialization. + * + * @since 3.0.0 */ class DataTypeJsonSerializer extends JsonSerializer[DataType] { Review comment: classes in the catalyst package are treated as private classes and we don't really need to add the `private[sql]` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org