From reviews-return-1043108-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Feb 19 13:04:37 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 90B8A180658 for ; Wed, 19 Feb 2020 14:04:37 +0100 (CET) Received: (qmail 14566 invoked by uid 500); 19 Feb 2020 13:04:37 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 14554 invoked by uid 99); 19 Feb 2020 13:04:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Feb 2020 13:04:36 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] cloud-fan commented on a change in pull request #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes Message-ID: <158211747685.7479.11623536094649969190.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 19 Feb 2020 13:04:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cloud-fan commented on a change in pull request #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes URL: https://github.com/apache/spark/pull/27628#discussion_r381276518 ########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala ########## @@ -403,11 +403,18 @@ case class Divide(left: Expression, right: Expression) extends DivModLike { """, since = "3.0.0") // scalastyle:on line.size.limit -case class IntegralDivide(left: Expression, right: Expression) extends DivModLike { +case class IntegralDivide( + left: Expression, + right: Expression, + returnLong: Boolean) extends DivModLike { Review comment: so the non-expression parameter doesn't count? Then I'm fine with it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org