From reviews-return-1039577-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Feb 14 17:17:31 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A617D180647 for ; Fri, 14 Feb 2020 18:17:30 +0100 (CET) Received: (qmail 22507 invoked by uid 500); 14 Feb 2020 17:17:30 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 22495 invoked by uid 99); 14 Feb 2020 17:17:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Feb 2020 17:17:30 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] Eric5553 commented on a change in pull request #27509: [SPARK-30764][SQL] Improve the readability of EXPLAIN FORMATTED style Message-ID: <158170064998.27441.16926153630931602140.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 14 Feb 2020 17:17:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Eric5553 commented on a change in pull request #27509: [SPARK-30764][SQL] Improve the readability of EXPLAIN FORMATTED style URL: https://github.com/apache/spark/pull/27509#discussion_r379549380 ########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala ########## @@ -189,8 +189,11 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanT val codegenIdStr = getTagValue(QueryPlan.CODEGEN_ID_TAG).map(id => s"[codegen id : $id]").getOrElse("") val operatorId = getTagValue(QueryPlan.OP_ID_TAG).map(id => s"$id").getOrElse("unknown") + val argStr = argString(SQLConf.get.maxToStringFields) + s""" |($operatorId) $nodeName $codegenIdStr + |Arguments: ${if (argStr != null && !argStr.isEmpty) argStr else "None"} Review comment: +1, thanks for the suggestion! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org