From reviews-return-1033476-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Feb 7 15:19:53 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CC3F018060E for ; Fri, 7 Feb 2020 16:19:52 +0100 (CET) Received: (qmail 82617 invoked by uid 500); 7 Feb 2020 15:19:52 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 82605 invoked by uid 99); 7 Feb 2020 15:19:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Feb 2020 15:19:52 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] srowen commented on issue #27491: [SPARK-30754][SQL] Reuse results of floorDiv in calculations of floorMod in DateTimeUtils Message-ID: <158108879213.17006.15236551287317598055.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 07 Feb 2020 15:19:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit srowen commented on issue #27491: [SPARK-30754][SQL] Reuse results of floorDiv in calculations of floorMod in DateTimeUtils URL: https://github.com/apache/spark/pull/27491#issuecomment-583448566 It's pretty trivially faster, I'd imagine, but the logic looks sound and it's not more complex ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org