From reviews-return-1030727-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Feb 5 01:13:15 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id F302218064E for ; Wed, 5 Feb 2020 02:13:14 +0100 (CET) Received: (qmail 22930 invoked by uid 500); 5 Feb 2020 01:13:14 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 22917 invoked by uid 99); 5 Feb 2020 01:13:14 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2020 01:13:14 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] HyukjinKwon commented on a change in pull request #27459: [SPARK-30510][SQL][DOCS] Publicly document Spark SQL configuration options Message-ID: <158086519428.11897.7008561256250510719.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 05 Feb 2020 01:13:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit HyukjinKwon commented on a change in pull request #27459: [SPARK-30510][SQL][DOCS] Publicly document Spark SQL configuration options URL: https://github.com/apache/spark/pull/27459#discussion_r375012035 ########## File path: sql/gen-sql-markdown.py ########## @@ -47,6 +53,18 @@ def _list_function_infos(jvm): return sorted(infos, key=lambda i: i.name) +def _list_sql_configs(jvm): + sql_configs = [ + SQLConfEntry( + name=_sql_config._1(), + default=_sql_config._2(), Review comment: I vaguely suspect it's because of some default values like `Option`. I will take a close look within few days. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org