spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon opened a new pull request #27615: [SPARK-29148][CORE][FOLLOW-UP] Don't dynamic allocation warning when it's disabled
Date Tue, 18 Feb 2020 05:29:18 GMT
HyukjinKwon opened a new pull request #27615: [SPARK-29148][CORE][FOLLOW-UP] Don't dynamic
allocation warning when it's disabled
URL: https://github.com/apache/spark/pull/27615
 
 
   ### What changes were proposed in this pull request?
   
   Currently, after https://github.com/apache/spark/pull/27313, it shows the warning about
dynamic allocation which is disabled by default.
   
   ```bash
   $ ./bin/spark-shell
   ```
   
   ```
   ...
   20/02/18 11:04:56 WARN ResourceProfile: Please ensure that the number of slots available
on your executors is 
   limited by the number of cores to task cpus and not another custom resource. If cores is
not the limiting resource 
   then dynamic allocation will not work properly!
   ```
   
   This PR brings back the configuration checking for this warning. Seems mistakenly removed
at https://github.com/apache/spark/pull/27313/files#diff-364713d7776956cb8b0a771e9b62f82dL2841
   
   ### Why are the changes needed?
   
   To remove false warning.
   
   ### Does this PR introduce any user-facing change?
   
   Yes, it will don't show the warning. It's master only change so no user-facing to end users.
   
   ### How was this patch tested?
   
   Manually tested.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message