spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] Eric5553 opened a new pull request #27511: Refine base operator abstraction code style
Date Sun, 09 Feb 2020 15:29:31 GMT
Eric5553 opened a new pull request #27511: Refine base operator abstraction code style
URL: https://github.com/apache/spark/pull/27511
 
 
   ### What changes were proposed in this pull request?
   When doing base operator abstraction work, we found there are still some code snippet is
 inconsistent with other abstraction code style. This PR addressed following two code refactor
cases.
   
   **Case 1** Override keyword missed for some fields in derived classes. The compiler will
not capture it if we rename some fields in the future.
   https://github.com/apache/spark/pull/27368#discussion_r376694045
   Most operators followed the practice, except:
   `EvalPythonExec` `BaseSubqueryExec` `HashJoin` `DataSourceScanExec`
   `ObjectProducerExec` `LimitExec` `WatermarkSupport` `V1FallbackWriters`
   `SupportsV1Write` `V2TableWriteExec` `WindowExecBase`
   
   **Case 2** Inconsistent abstract class filed definition. The updated style will simplify
derived class definition.
   https://github.com/apache/spark/pull/27368#discussion_r375061952
   Most operators followed the practice, except:
   `EvalPythonExec` `WindowExecBase`
   
   
   ### Why are the changes needed?
   Improve the code style consistency and code quality
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   Existing tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message