spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] beliefer commented on a change in pull request #27734: [SPARK-30908][CORE][DOC] Add version information to the configuration of Kryo
Date Fri, 28 Feb 2020 10:25:35 GMT
beliefer commented on a change in pull request #27734: [SPARK-30908][CORE][DOC] Add version
information to the configuration of Kryo
URL: https://github.com/apache/spark/pull/27734#discussion_r385617178
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/Kryo.scala
 ##########
 @@ -22,35 +22,43 @@ import org.apache.spark.network.util.ByteUnit
 private[spark] object Kryo {
 
   val KRYO_REGISTRATION_REQUIRED = ConfigBuilder("spark.kryo.registrationRequired")
+    .version("1.1.0")
     .booleanConf
     .createWithDefault(false)
 
   val KRYO_USER_REGISTRATORS = ConfigBuilder("spark.kryo.registrator")
+    .version("0.5.0")
 
 Review comment:
   No JIRA ID, commit ID: 91c07a33d90ab0357e8713507134ecef5c14e28a#diff-792ed56b3398163fa14e8578549d0d98
   This is not a release version, do we need to record it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message