spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] Ngone51 commented on a change in pull request #27693: [SPARK-30947][CORE] Log better message when accelerate resource is empty
Date Wed, 26 Feb 2020 15:04:42 GMT
Ngone51 commented on a change in pull request #27693: [SPARK-30947][CORE] Log better message
when accelerate resource is empty
URL: https://github.com/apache/spark/pull/27693#discussion_r384550564
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala
 ##########
 @@ -362,8 +362,13 @@ private[spark] object ResourceUtils extends Logging {
 
   def logResourceInfo(componentName: String, resources: Map[String, ResourceInformation])
     : Unit = {
+    val resourceInfo = if (resources.isEmpty) {
+      s"No extra accelerate resources configured for $componentName."
+    } else {
+      s"Accelerate Resources for $componentName:\n${resources.mkString("\n")}"
 
 Review comment:
   addressed, thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message