spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] srowen commented on a change in pull request #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines
Date Wed, 26 Feb 2020 14:42:25 GMT
srowen commented on a change in pull request #27546: [SPARK-30773][ML]Support NativeBlas for
level-1 routines
URL: https://github.com/apache/spark/pull/27546#discussion_r384534200
 
 

 ##########
 File path: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala
 ##########
 @@ -220,20 +240,12 @@ private[spark] object BLAS extends Serializable {
       case sx: SparseVector =>
         f2jBLAS.dscal(sx.values.length, a, sx.values, 1)
 
 Review comment:
   I think you can apply the optimization here too; just depends on the length of sx.values

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message