spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] imback82 commented on a change in pull request #27532: [SPARK-30782][SQL] Column resolution doesn't respect current catalog/namespace for v2 tables.
Date Wed, 26 Feb 2020 03:17:05 GMT
imback82 commented on a change in pull request #27532: [SPARK-30782][SQL] Column resolution
doesn't respect current catalog/namespace for v2 tables.
URL: https://github.com/apache/spark/pull/27532#discussion_r384254816
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -933,7 +935,7 @@ class Analyzer(
               v1SessionCatalog.getRelation(v1Table.v1Table)
             case table =>
               SubqueryAlias(
-                identifier,
+                ident.asMultipartIdentifier,
 
 Review comment:
   We could, but it will fallback to the new column resolution algo: https://github.com/apache/spark/pull/27391#discussion_r383091921.
I was thinking about adding this support when I update the resolution rule.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message