spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] MaxGekk commented on a change in pull request #27618: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
Date Tue, 25 Feb 2020 04:57:11 GMT
MaxGekk commented on a change in pull request #27618: [SPARK-30869][SQL] Convert dates to/from
timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27618#discussion_r383658716
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
 ##########
 @@ -591,8 +587,8 @@ object DateTimeUtils {
     }
     // using milliseconds can cause precision loss with more than 8 digits
     // we follow Hive's implementation which uses seconds
-    val secondsInDay1 = MILLISECONDS.toSeconds(millis1 - daysToMillis(date1, zoneId))
 
 Review comment:
   The error of rounding is invisible in dividing by `DAYS.toSeconds(31)`. At least, I haven't
reproduce the issue yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message