spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] beliefer commented on a change in pull request #27674: [SPARK-30888][CORE][DOC] Add version information to the configuration of Network
Date Mon, 24 Feb 2020 05:26:55 GMT
beliefer commented on a change in pull request #27674: [SPARK-30888][CORE][DOC] Add version
information to the configuration of Network
URL: https://github.com/apache/spark/pull/27674#discussion_r383089999
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/Network.scala
 ##########
 @@ -23,71 +23,85 @@ private[spark] object Network {
 
   private[spark] val NETWORK_CRYPTO_SASL_FALLBACK =
     ConfigBuilder("spark.network.crypto.saslFallback")
+      .version("2.2.0") // SPARK-19139, commit ID: 8f3f73abc1fe62496722476460c174af0250e3fe
       .booleanConf
       .createWithDefault(true)
 
   private[spark] val NETWORK_CRYPTO_ENABLED =
     ConfigBuilder("spark.network.crypto.enabled")
+      .version("2.2.0") // SPARK-19139, commit ID: 8f3f73abc1fe62496722476460c174af0250e3fe
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val NETWORK_REMOTE_READ_NIO_BUFFER_CONVERSION =
     ConfigBuilder("spark.network.remoteReadNioBufferConversion")
+      .version("2.4.0") // SPARK-24307, commit ID: 2c82745686f4456c4d5c84040a431dcb5b6cb60b
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val NETWORK_TIMEOUT =
     ConfigBuilder("spark.network.timeout")
+      .version("1.3.0") // SPARK-4688, commit ID: d3f07fd23cc26a70f44c52e24445974d4885d58a
       .timeConf(TimeUnit.SECONDS)
       .createWithDefaultString("120s")
 
   private[spark] val NETWORK_TIMEOUT_INTERVAL =
     ConfigBuilder("spark.network.timeoutInterval")
+      .version("1.3.2") // SPARK-5529, commit ID: ec196ab1c7569d7ab0a50c9d7338c2835f2c84d5
       .timeConf(TimeUnit.MILLISECONDS)
       .createWithDefaultString(STORAGE_BLOCKMANAGER_TIMEOUTINTERVAL.defaultValueString)
 
   private[spark] val RPC_ASK_TIMEOUT =
     ConfigBuilder("spark.rpc.askTimeout")
+      .version("1.4.0") // SPARK-6490, commit ID: 8136810dfad12008ac300116df7bc8448740f1ae
       .stringConf
       .createOptional
 
   private[spark] val RPC_CONNECT_THREADS =
     ConfigBuilder("spark.rpc.connect.threads")
+      .version("1.6.0") // SPARK-6028, commit ID: 084e4e126211d74a79e8dbd2d0e604dd3c650822
       .intConf
       .createWithDefault(64)
 
   private[spark] val RPC_IO_NUM_CONNECTIONS_PER_PEER =
     ConfigBuilder("spark.rpc.io.numConnectionsPerPeer")
+      .version("1.6.0") // SPARK-10745, commit ID: 34a77679877bc40b58a10ec539a8da00fed7db39
       .intConf
       .createWithDefault(1)
 
   private[spark] val RPC_IO_THREADS =
     ConfigBuilder("spark.rpc.io.threads")
+      .version("1.6.0") // SPARK-6028, commit ID: 084e4e126211d74a79e8dbd2d0e604dd3c650822
       .intConf
       .createOptional
 
   private[spark] val RPC_LOOKUP_TIMEOUT =
     ConfigBuilder("spark.rpc.lookupTimeout")
+      .version("1.4.0") // SPARK-6490, commit ID: 8136810dfad12008ac300116df7bc8448740f1ae
 
 Review comment:
   SPARK-6490, commit ID: 8136810dfad12008ac300116df7bc8448740f1ae

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message