spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] otterc commented on a change in pull request #27665: [SPARK-24355][Core][FOLLOWUP] Add flag for fetching chunks in async mode
Date Fri, 21 Feb 2020 19:26:02 GMT
otterc commented on a change in pull request #27665: [SPARK-24355][Core][FOLLOWUP] Add flag
for fetching chunks in async mode
URL: https://github.com/apache/spark/pull/27665#discussion_r382763278
 
 

 ##########
 File path: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java
 ##########
 @@ -124,7 +127,13 @@ private ChannelFuture respond(
       final Channel channel,
       final Encodable result) throws InterruptedException {
     final SocketAddress remoteAddress = channel.remoteAddress();
-    return channel.writeAndFlush(result).await().addListener((ChannelFutureListener) future
-> {
+    ChannelFuture channelFuture = null;
+    if (chunkFetchAsyncModeEnabled) {
+      channelFuture = channel.writeAndFlush(result);
 
 Review comment:
   When we remove `await`, we see more SASL requests timing out. I mentioned this in the comment
here:
   https://github.com/apache/spark/pull/22173#issuecomment-578347705
   
   Wouldn't making the `asyncMode` default, make this problem worse?
   In aysnc mode, how do you plan to tackle increased number of SASL failures?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message