spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon commented on a change in pull request #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Date Fri, 21 Feb 2020 10:07:00 GMT
HyukjinKwon commented on a change in pull request #27666: [SPARK-30896]:The behavior of JsonToStructs
should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#discussion_r382497137
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
 ##########
 @@ -604,6 +608,20 @@ case class JsonToStructs(
   override def prettyName: String = "from_json"
 }
 
+object JsonToStructs{
 
 Review comment:
   @lipzhu Please run the linter `./dev/lint-scala` and fix the style.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message